Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove history locations from inputs/outputs #350

Open
Pfoerd opened this issue Aug 14, 2023 · 2 comments
Open

Remove history locations from inputs/outputs #350

Pfoerd opened this issue Aug 14, 2023 · 2 comments

Comments

@Pfoerd
Copy link
Contributor

Pfoerd commented Aug 14, 2023

The gradle docs on incremental builds say

don’t register properties as inputs if they don’t affect the output

As the pitest history file doesn't affect the results of mutation analysis, the properties historyInputLocation, defaultFileForHistoryData and historyOutputLocation should not be added to inputs/outputs of PitestTask, but should instead be treated like internal task properties.

This is important e.g. when sharing history files across builds: currently the PitestTask is considered to be out-of-date even when only the history file changed since the last successful run (e.g. because a new history file was provided by another build). Thus, mutation analysis is executed but the results will of course always be the same.

@Pfoerd
Copy link
Contributor Author

Pfoerd commented Sep 4, 2023

@szpak do you have any feedback on this?

This blocks us from integrating history support in our CI pipeline as history file handling depends on whether this will be fixed in the pitest-plugin. Otherwise we have to implement a workaround.

@Pfoerd
Copy link
Contributor Author

Pfoerd commented Feb 1, 2024

Hi @szpak do you have any feedback on this?

This is really a pain as it increases build times of CI builds by hours for no reason.

If it helps, I can provide a PR, but I don't want to make the effort unless you're really interested. Unfortunately I've seen that this projects seems to be inactive for a while?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant