Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

App crashes when no quantitiy is entered in MedicineStoreFragment #356

Open
3 tasks
aayushinigam opened this issue Jul 29, 2018 · 11 comments · May be fixed by #374
Open
3 tasks

App crashes when no quantitiy is entered in MedicineStoreFragment #356

aayushinigam opened this issue Jul 29, 2018 · 11 comments · May be fixed by #374

Comments

@aayushinigam
Copy link
Collaborator

aayushinigam commented Jul 29, 2018 •
edited
Loading

Description

As a user,
I need to be notified when quantity is not entered in MedicineStore,
so that I can update it.

Acceptance Criteria

Update [Required]

  • Handle error in MedicineStoreFragment

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 hour
@geekanamika
Copy link
Member

geekanamika commented Jul 29, 2018 •
edited
Loading

I believe, it's MedicineStoreFragment, right(issue title)?
Since, It won't include major changes, send PR which solve this issue along with #347 :)

@aayushinigam aayushinigam changed the title App crashes when no quantitiy is entered in MedicineStoreActivity App crashes when no quantitiy is entered in MedicineStoreFragment Jul 29, 2018
@mohak1283
Copy link

I would like to work on this issue

@geekanamika
Copy link
Member

Hey @mohak1283 , I've already assigned one issue to you, complete it & then you can claim it later if available.

@mohak1283
Copy link

Okay @geekanamika

@geekanamika
Copy link
Member

@aayushinigam Any updates on this issue?

@aayushinigam
Copy link
Collaborator Author

aayushinigam commented Aug 12, 2018 •
edited
Loading

@geekanamika I have solved this but the problem that I notified you about on slack still exists. Now that you are free from gsoc work, could you please check that code(I shared its link on slack)?

@shikherjaiswal
Copy link

Is the issue available? If so ,I would like to work on this @geekanamika

@aayushinigam
Copy link
Collaborator Author

@shikherjaiswal You can take this up!

@shikherjaiswal
Copy link

@aayushinigam @geekanamika do I need to submit a PR solving this issue and issue #347 in this PR ?

@aayushinigam
Copy link
Collaborator Author

Yes. You have to solve both the issues in the same PR.

@shikherjaiswal shikherjaiswal linked a pull request Sep 4, 2018 that will close this issue
Open
7 tasks
@shikherjaiswal
Copy link

@aayushinigam @geekanamika Please review my PR .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@geekanamika @shikherjaiswal @aayushinigam @mohak1283