Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peci: Unplugging display from TBT port causes GetTemp() timeouts #369

Open
crawfxrd opened this issue Jun 21, 2023 · 0 comments
Open

peci: Unplugging display from TBT port causes GetTemp() timeouts #369

crawfxrd opened this issue Jun 21, 2023 · 0 comments

Comments

@crawfxrd
Copy link
Member

crawfxrd commented Jun 21, 2023

  • Model: oryp11
  • EC version: dd555b9
  • OS: Pop!_OS 22.04
  • Kernel: 6.2.7-060207-generic

Unplugging a display connected to the TBT port on oryp11 causes PECI GetTemp() timeouts.

Steps to reproduce

  1. Plug in a display to the TBT port
  2. Power on system, booting to OS
  3. Unplug the display
  4. Power off or reboot the system

Expected behavior

  • System shuts down to S5 or reboots to OS

Actual behavior

  • System hangs during shutdown
  • peci_get_temp() timeouts are logged by the EC

Additional info

This specifically affects the PECI-over-eSPI implementation, currently only used by oryp11.

Acknowledging the completion in #368 fixed it from hanging on shutdown.

Presumably, this could happen because of

  • invalid/insufficient checks in peci_available()
  • missing the check to see if a transaction is currently in progress in peci_get_temp()
@crawfxrd crawfxrd changed the title oryp11: Unplugging display from TBT port causes PECI timeout peci: Unplugging display from TBT port causes GetTemp() timeouts Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant