Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore to scaffolding process #76

Open
CodeSpent opened this issue Jan 22, 2021 · 3 comments
Open

Add .gitignore to scaffolding process #76

CodeSpent opened this issue Jan 22, 2021 · 3 comments

Comments

@CodeSpent
Copy link

I'm not sure if this is an oversight, or intentional, but I'd love to have the discussion documented. There is currently no .gitignore boilerplate, which adds a little extra work after starting the project. I'm proposing adding this, and potentially also adding the git init step to the scaffolding process.

I think it is fair to assume (or just provide an option) that someone would be using git for these projects, so could be a tiny win to go from running the create apollo-app command to writing code straight away.

I'm happy to contribute this if maintainers approve of this idea?

@CodeSpent CodeSpent changed the title Missing gitignore Add .gitignore to scaffolding process Jan 22, 2021
@larixer
Copy link
Member

larixer commented Jan 23, 2021

@CodeSpent I'm fine with this idea, but we should ignore git init errors, so that if use do not have git installed it won't fail

@CodeSpent
Copy link
Author

@larixer great, I can handle that. Do you think it'd make more sense to add a second option after the initial menu selection asking the user if they want to initialize git? Can still fail silently, but this would also let them opt out of a .gitignore if for any reason they don't want one.

@larixer
Copy link
Member

larixer commented Jan 23, 2021

@CodeSpent I think pretty much everyone uses git these days, so just failing with a warning is fine, IMO, no need to complicate the task for yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants