Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mobile] remove expo-camera dependency #1229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[mobile] remove expo-camera dependency #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/chat/client-react/containers/withImage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react';
import Constants from 'expo-constants';
import Camera from 'expo-camera';
import * as FileSystem from 'expo-file-system';
import { ImagePicker } from 'expo-image-picker';
import { ReactNativeFile } from 'apollo-upload-client';
Expand Down Expand Up @@ -109,7 +108,7 @@ export default (Component) => {
if (skip === Platform.OS) {
return true;
}
const { status } = await Camera.requestPermissionsAsync();
const { status } = await ImagePicker.requestCameraPermissionsAsync();
return status === 'granted';
};

Expand Down
1 change: 0 additions & 1 deletion packages/mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"apollo-logger": "^0.3.3",
"apollo-upload-client": "^10.0.0",
"expo": "^45.0.0",
"expo-camera": "~12.2.0",
"expo-cli": "^5.4.3",
"expo-constants": "~13.1.1",
"expo-file-system": "~14.0.0",
Expand Down
32 changes: 0 additions & 32 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3694,17 +3694,6 @@ __metadata:
languageName: node
linkType: hard

"@koale/useworker@npm:^4.0.2":
version: 4.0.2
resolution: "@koale/useworker@npm:4.0.2"
dependencies:
dequal: ^1.0.0
peerDependencies:
react: ^16.8.0
checksum: 2b55f88fcaffdbcdb0bea0b576f1badd62faba76a4c6120ffe0e23e5f112d840b0be19dd791c0f0c162e1f2a24e9c2dfbd5d37870fe182d1e9b3b1ee72a4f0c4
languageName: node
linkType: hard

"@leichtgewicht/ip-codec@npm:^2.0.1":
version: 2.0.4
resolution: "@leichtgewicht/ip-codec@npm:2.0.4"
Expand Down Expand Up @@ -14829,13 +14818,6 @@ __metadata:
languageName: node
linkType: hard

"dequal@npm:^1.0.0":
version: 1.0.1
resolution: "dequal@npm:1.0.1"
checksum: 3d2727637546257edbb1e98c49267726b37499213533eefdd6d23bf1596cf5bb9a716947aa6ed7bfe3ef2cf5c0958a0422da7b554553b82ea19eaa2d3e92848f
languageName: node
linkType: hard

"des.js@npm:^1.0.0":
version: 1.0.1
resolution: "des.js@npm:1.0.1"
Expand Down Expand Up @@ -16575,19 +16557,6 @@ __metadata:
languageName: node
linkType: hard

"expo-camera@npm:~12.2.0":
version: 12.2.0
resolution: "expo-camera@npm:12.2.0"
dependencies:
"@expo/config-plugins": ^4.0.14
"@koale/useworker": ^4.0.2
invariant: ^2.2.4
peerDependencies:
expo: "*"
checksum: 449a0a2595d88ebd487213ba952a34c64fde46235812aab3f87b666a33efda01199d70ff56522c0c8d4499b7f5cb8423ad0dfcf8b80fc9884d3fc698c0cd95f4
languageName: node
linkType: hard

"expo-cli@npm:^5.4.3":
version: 5.4.6
resolution: "expo-cli@npm:5.4.6"
Expand Down Expand Up @@ -25510,7 +25479,6 @@ __metadata:
cross-env: ^5.1.1
eslint: ^8.15.0
expo: ^45.0.0
expo-camera: ~12.2.0
expo-cli: ^5.4.3
expo-constants: ~13.1.1
expo-file-system: ~14.0.0
Expand Down