Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more useful container checks #33

Merged
merged 9 commits into from
Aug 2, 2024
Merged

Add more useful container checks #33

merged 9 commits into from
Aug 2, 2024

Conversation

daun
Copy link
Member

@daun daun commented Aug 1, 2024

Description

  • Make debug plugin useful again 🤠 — prompted by docs update about known issues
  • Warn about some common mistakes early on
    • Add check if containers are present initially
    • Add check if container selector matches multiple elements
    • Add check if any of the containers matches the animation selector
  • Refactor checks into instance methods
  • Tested in playground

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Copy link
Member

@hirasso hirasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚚💨

@daun daun merged commit 92412ac into master Aug 2, 2024
1 check passed
@daun daun deleted the feat/container-check branch August 2, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants