Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze RedisDelLuaScriptTests #9

Open
mcweba opened this issue Dec 18, 2015 · 0 comments
Open

Analyze RedisDelLuaScriptTests #9

mcweba opened this issue Dec 18, 2015 · 0 comments

Comments

@mcweba
Copy link
Collaborator

mcweba commented Dec 18, 2015

The class RedisDelLuaScriptTests.java contains unit tests for the delete lua script. This class has a helper method to create the delete command:

evalScriptDel(final String resourceName, final long maxscore)

This helper method has a parameter "maxscore" which is not used. Clearly this is a bug. Fixing this bug causes the test deleteNotExpiredResourceOfTwo() to fail. It has to be analyzed whether this test is not correct or there's a bug in the implementation of the delete lua script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcweba