Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hierarchy should show fully qualified type for nested types #1673

Open
ahoppen opened this issue Sep 16, 2024 · 1 comment · May be fixed by #1844
Open

Type hierarchy should show fully qualified type for nested types #1673

ahoppen opened this issue Sep 16, 2024 · 1 comment · May be fixed by #1844

Comments

@ahoppen
Copy link
Member

ahoppen commented Sep 16, 2024

If you have a type hierarchy like

protocol MyProto {}

struct Outer {
  struct Inner: MyProto {}
}

and you show the type hierarchy of MyProto, it should show Outer.Inner as one of its children, not just Inner.
@ahoppen
Copy link
Member Author

ahoppen commented Sep 16, 2024

Synced to Apple’s issue tracker as rdar://136078089

ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Nov 22, 2024
@ahoppen
Fully qualify type names in call hierarchy, type hierarchy and worksp…
37034a8 
…ace symbols

Previously, we didn’t take outer types into account or only took one level of container type into account.

Fixes swiftlang#1673
136078089
@ahoppen ahoppen linked a pull request Nov 22, 2024 that will close this issue
Open
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Nov 22, 2024
@ahoppen
Fully qualify type names in call hierarchy, type hierarchy and worksp…
eb72e10 
…ace symbols

Previously, we didn’t take outer types into account or only took one level of container type into account.

Fixes swiftlang#1673
rdar://136078089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ahoppen