Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown result is non-null #1733

Open
mattmassicotte opened this issue Oct 1, 2024 · 1 comment · May be fixed by #1842
Open

shutdown result is non-null #1733

mattmassicotte opened this issue Oct 1, 2024 · 1 comment · May be fixed by #1842
Labels
bug Something isn't working

Comments

@mattmassicotte
Copy link

Swift version

swift-6.0-DEVELOPMENT-SNAPSHOT-2024-09-17-a

Platform

macOS 14.5

Editor

https://github.com/ChimeHQ/LanguageClient

Description

In response to a shutdown request, the server responds with:

{"jsonrpc":"2.0","id":2,"result":{}}

That result of {} doesn't match the specification, which indices that the result should be null.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#shutdown

This really isn't that big a deal, but we found it, and figured it was worth reporting.

Steps to Reproduce

send a shutdown request

Logging

No response
@mattmassicotte mattmassicotte added the bug Something isn't working label Oct 1, 2024
@mattmassicotte mattmassicotte mentioned this issue Oct 1, 2024
Open
@ahoppen
Copy link
Member

ahoppen commented Oct 14, 2024

Synced to Apple’s issue tracker as rdar://137886488

ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Nov 22, 2024
@ahoppen
Reply with null to shutdown request
e073a01 
The LSP spec says the result of `shutdown` is `null`, not an empty object.

Fixes swiftlang#1733
rdar://137886488
@ahoppen ahoppen linked a pull request Nov 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reply with null to shutdown request ahoppen/sourcekit-lsp
2 participants
@mattmassicotte @ahoppen