Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a real PR. This should be used to gather input if we want this or not, while also being used as a quick reproduction.
Relates #308
Idea is to solve the problem more globally and in a future-proof way. After the
all-addons
test has run, we will initiatepnpm lint
(which runsprettier
andeslint
behind the scenes) if any of our generated code does not match the linting rules we enforce while addingeslint
andprettier
respectively. If we want to keep this kind of test in the future, we should properly separate into it's own test that exclusively tests linting all add-ons. But this is enough to get a rough idea.To summarize, the results are pretty bad. After running
pnpm format
on the results of the test i got 36 files that did not match the prettier output (4 of those with EOL mismatches). Most of the files are related to the spaces / tabs issue we were trying to solve with #100 (roughly 9 files). Another 10 files are created outside of our control (storbook
'ssrc/stories
folder), but that would still leave us with 22 wrongly formatted files.If we add
eslint
to the story, we get another 5 errors (3paraglide
, 1lucia
, 1storybook
).I do think this is an important test to have, but I think the timing is off. We first need to solve a few of those other issues, especially the tabs / spaces one.