-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic download and build of MOAB #969
base: develop
Are you sure you want to change the base?
Conversation
@ahnaf-tahmid-chowdhury @shimwell @gonuke even if this is still a draft, feel free to provide any feed back! |
cmake/FindMOAB.cmake
Outdated
else() | ||
# message(FATAL_ERROR "Could not find MOAB") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still return a fatal_error if ExternalProject
encounters an issue
The safeguard I added should be improve... (i.e.: have them only MOAB download is triggered...) |
@gonuke this still needs some polishing here and there, but I think this is ready for a first opinion. |
change location cmake up cmake up cmake up CMAKE_MODULE_PATH CMAKE_MODULE_PATH CMAKE_MODULE_PATH adding LIBS adding LIBS install_dependent_library(MOAB ) install_dependent_library adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE tmp get the safeguard revert unnecessary change
Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the update. I have a few comments for improvement.
-DBUILD_SHARED_LIBS:BOOL=ON | ||
-DENABLE_HDF5:BOOL=ON | ||
-DHDF5_ROOT:PATH=${HDF5_ROOT} | ||
-DCMAKE_INSTALL_RPATH=${HDF5_ROOT}/lib:${MOAB_INSTALL_PREFIX}/lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method may work here for now, but may create trouble while working with scikit-build-core depended project. However, I am not sure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no experience about scikit-build-core
, maybe we shall fix it, if the problem occurs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe MOAB master branch now has scikit-build core while version 5.5.1 does not.
Perhaps changing the moab version to master would provide a quick way of checking if this continues to work
GIT_REPOSITORY https://bitbucket.org/fathomteam/moab.git
GIT_TAG ${moab_version}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying it now.
@@ -50,6 +50,9 @@ jobs: | |||
5.4.1, | |||
5.5.1, | |||
] | |||
ddl_deps : [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is like Enable Download MOAB or Double Down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only enables MOAB Download, otherwise everything work as it used to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion about the name of the variable,
but eventually one might want to include Embree
and DD
the same way...
if your question is about the addition into the matrix, I needed it to allow the CI to test for this kind of build...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to pass, I'll revert the change
Testing locally with this docker file and it compiles for me
|
Description
Add capability to automate pull and build MOAB at DAGMC building time
This is redondant with #964
Motivation and Context
This is part of the project from @shimwell on getting a pip install for OpenMC with DAGMC.
Changes
tweaked a little bit the
findMOAB.cmake
Behavior
Nothing changes if DDL_DEPS is not set at ON on Cmake configuration.
Otherwise pull build MOAB from MOAB repo builds it, and build the DAGMC lib against it.
Changelog file
This is very much inspired by @ahnaf-tahmid-chowdhury work on PyNE cmake.
This works is sponsored by Proxima Fusion