Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to support different achievements for different versions #116

Open
Alayan-stk-2 opened this issue Dec 18, 2018 · 5 comments
Open

Allow to support different achievements for different versions #116

Alayan-stk-2 opened this issue Dec 18, 2018 · 5 comments

Comments

@Alayan-stk-2
Copy link

Currently, the addition/change of achievements in STK is pretty much frozen because of stk-addons side limitations. This means that despite new achievements (not counting the sync with server) having been made much easier to add in STK, it's still not possible to do so.

@vampy
Copy link
Member

vampy commented Jan 13, 2019

I don't get why achievements are frozen to be honest, until now when an achievement was added in the xml file I just ran a script and everything was updated.

Even if versioning is added someone still needs to manually import achievements from stk-code into stk-addons

@Alayan-stk-2
Copy link
Author

The idea is that e.g. we don't want the Christoffel Columbus of 0.9.1 to apply to 0.10 where half of the tracks have been changed. Or we may want to change a lot/remove an achievement at some point, not just add something new. So we'd use 2 separate IDs for the two versions of the achievement.

Also, even if you can run a simple script to update, Benau and Auria are worried about the website-side update and that's exactly why I have not added anything more until now.

We had several discussions about this on the IRC, you can find it in the october logs (mostly the 7th and the following days.

As a side-question : would it be possible to create one server-authoritative achievement ? That is, the stk addons server and not the local stk instance decides if the achievement has been gotten and the sync only gives it to the local version (I'm think about an achievement for networked multiplayer).

@vampy
Copy link
Member

vampy commented Jan 13, 2019

I don't get why they are worried, it worked so far when hiker added new achievements 🤷‍♂️.

And yes achievement versioning would be nice.

Possible yes, but it depends on what kind of achievements are you thinking about, for example: player played 100 network games kind of achievement?

@Alayan-stk-2
Copy link
Author

"Player played 100 network games" or "Player got X ranking points" kind of achievement.

@auriamg
Copy link
Member

auriamg commented Jan 13, 2019

My understanding is that the issue is when the same achievement changes from version to version.

First thing that comes to my mind could be that each achievement on the server could have a "from stk version" and "to stk version" fields. So if achievement "Played all tracks" no longer makes sense in the ne version since all tracks have changed too much, then the old "Player all tracks" achivement could be marked with "stk version <= 0.9.3", and then we create a new similar achievement marked "stk version >= 0.10.0"

other solution are welcome if you have them though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants