Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return duplicate ports from SRV query #1656

Open
tpantelis opened this issue Oct 2, 2024 · 0 comments · May be fixed by #1685
Open

Don't return duplicate ports from SRV query #1656

tpantelis opened this issue Oct 2, 2024 · 0 comments · May be fixed by #1685
Assignees
@tpantelis
Labels
bug Something isn't working priority:medium

Comments

@tpantelis
Copy link
Contributor

tpantelis commented Oct 2, 2024 •
edited
Loading

If a service is defined with two ports with the same port number but different protocols, eg

Ports: []corev1.ServicePort{
    {
        Name:     "tcp",
        Port:     42,
        Protocol: corev1.ProtocolTCP,
    },
    {
        Name:     "udp",
        Port:     42,
        Protocol: corev1.ProtocolUDP,
    },
},

LH returns both records:

0 50 42 hello.mcs-conformance-1655466269.svc.clusterset.local
0 50 42 hello.mcs-conformance-1655466269.svc.clusterset.local

while a .svc.cluster.local query returns only one of them. LH should do the same.
@tpantelis tpantelis added the bug Something isn't working label Oct 2, 2024
@tpantelis tpantelis self-assigned this Oct 2, 2024
@tpantelis tpantelis added this to Backlog Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Oct 2, 2024
@tpantelis tpantelis moved this from Backlog to Next Version Candidate in Backlog Oct 28, 2024
@maayanf24 maayanf24 removed this from Backlog Oct 29, 2024
@maayanf24 maayanf24 moved this to Todo in Submariner 0.20 Oct 29, 2024
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Nov 26, 2024
@tpantelis
Don't return duplicate ports from SRV query
7efd9bf 
Fixes submariner-io#1656

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Nov 26, 2024
@tpantelis
Don't return duplicate ports from SRV query
4f7f97e 
Fixes submariner-io#1656

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Nov 27, 2024
@tpantelis
Don't return duplicate ports from SRV query
7eca73c 
Fixes submariner-io#1656

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis linked a pull request Nov 27, 2024 that will close this issue
Open
@tpantelis tpantelis moved this from In Progress to In Review in Submariner 0.20 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpantelis tpantelis

Labels
bug Something isn't working priority:medium
Projects
Submariner 0.20
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't return duplicate ports from SRV query tpantelis/lighthouse
2 participants
@dfarrell07 @tpantelis