Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Package dependency #249

Open
jason-chen-kiewit opened this issue Apr 28, 2022 · 4 comments
Open

[Bug] Package dependency #249

jason-chen-kiewit opened this issue Apr 28, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@jason-chen-kiewit
Copy link

Describe the bug

I've recently upgraded my project to React v18 and Storybook to v6.5.0-beta.0 and am currently unable to run npm install @storybook/preset-create-react-app in the terminal without getting dependency errors (see screenshot below). Hoping this will be a simple peerDependencies change, but any help is appreciated!

Steps to reproduce the behavior

  1. npx create-react-app
  2. npx sb init
  3. npx sb upgrade --prerelease
  4. Delete node_modules
  5. npm install
  6. See error

Expected behavior

npm installs without dependency errors.

Screenshots and/or logs

image

Environment

  • OS: Mac OS X
  • Node.js version: 17.6.0
  • NPM version: 8.7.0

Additional context

N/A

@jason-chen-kiewit jason-chen-kiewit added the bug Something isn't working label Apr 28, 2022
@easga
Copy link

easga commented May 20, 2022

this issue is no more once the latest release (6.5.3) for storybook packages are used. Thanks for all those who made it happen, my storybook builds just fine :)

@SavePointSam
Copy link

Currently hitting this on fresh setup of Storybook using version 6.5.9 with preset version 4.1.2

@icebearlabs
Copy link

yep hitting this as well, throwing out @storybook/preset-create-react-app fixes the issue. Something in there is not right, yet.

@el-j
Copy link

el-j commented Nov 24, 2022

i used and override in package.json to fix this for storybook 7 alpha release:

"devDependecies": {
    "@storybook/addon-actions": "^7.0.0-alpha.52",
    "@storybook/addon-essentials": "^7.0.0-alpha.52",
    "@storybook/addon-interactions": "^7.0.0-alpha.52",
    "@storybook/addon-links": "^7.0.0-alpha.52",
    "@storybook/node-logger": "^7.0.0-alpha.52",
    "@storybook/preset-create-react-app": "^4.1.2", //this is the latest for now with old depencies
    "@storybook/react": "7.0.0-alpha.52",
    "@storybook/react-webpack5": "^7.0.0-alpha.52",
    "@storybook/testing-library": "^0.0.14-next.0",
},
"overrides": {
"@storybook/react": "7.0.0-alpha.52",
 "@storybook/preset-create-react-app": {
      "@storybook/react": "7.0.0-alpha.52"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants