-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] CRA5, [email protected] #225
Comments
I have the same issue |
I have a repro case here. |
Same issue, but in my case, disabling CRA is causing SVG import issues. Similar ticket: #228 |
Same here |
It worked when I upgraded Storybook to use Webpack 5 |
I think the problem may be here https://github.com/storybookjs/presets/blob/master/packages/preset-create-react-app/src/helpers/getReactScriptsPath.ts This code sets the path to the react-scripts folder. I don't think it covers all the cases. |
Describe the bug
npm run storybook does not run after upgrading CRA to 5.
Steps to reproduce the behavior
Expected behavior
storybook can run
Screenshots and/or logs
Environment
Workaround
Disabling @storybook/preset-create-react-app in .storybook/main.js, which is I guess not ideal.
The text was updated successfully, but these errors were encountered: