Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-24 popup window closes immediately #28

Closed
wants to merge 1 commit into from
Closed

Conversation

t0fudev
Copy link

@t0fudev t0fudev commented Oct 4, 2024

This is a WIP.

Closes #9.

I added the if statement to check for the events, however I was going to do some testing on checking the different types of status messages and create the if statement properly.

I got some issues while trying to search the SEP-24 popup window. I went to dashboard/transfers, but didn't see the title saying SEP-24 Transfers which is only shown once the stellar.toml is fetched (I understood this). Also, I'm not seeing any text besides the last paragraph which ends in line 330.

I would appreciate some guidance on how to show the SEP-24 Transfers title to open the popup window, and get the possible messages. After doing my implentation, I would test it properly. Thank you!

@ElliotFriend
Copy link
Contributor

Hi, there @t0fudev!! Thanks for taking on this task!

To see the relevant parts of the interface, follow the steps here to add the testanchor SRT:GCD...Y6B asset to your account, and then the further information will show up for you to examine.

Let me know if that helps get you going, or if there's any other trouble. Thanks!!

@t0fudev
Copy link
Author

t0fudev commented Oct 15, 2024

Hello @ElliotFriend!! Hope you're doing great,

I read the steps and followed them but can't replicate the bug. Also, Í watched closely every action on both buttons but can't see where do the popup close immediately. If you can help me it would be amazing! Thank you.

@ElliotFriend
Copy link
Contributor

Hi, @t0fudev! Once you have the asset added (as described in the link I posted above), click the "Transfers" button on the left-side of the screen. That'll take you to where you can authenticate with the anchor, and then you can click a "SEP-24 Deposit" (or something similar) button that will show up. Then, you'll see it open/close immediately.

@ElliotFriend
Copy link
Contributor

Hi, @t0fudev!

My guess is you've moved on to other projects for the time-being, or maybe just aren't as interested in implementing this feature as you once were (which is totally fine!). In any case, I'll close the PR, so it doesn't get too stale.

If you are still interested in working on this, we can definitely re-open the PR, and keep moving. Just let me know.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEP-24 popup window closes immediately
2 participants