-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stellar smart contract #24
base: main
Are you sure you want to change the base?
Conversation
@ElliotFriend please look through this draft PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, there @Ugo-X!! Thanks for taking on this PR! I think you're on the right track! Looks like there's still some functionality and work you've got left in front of you, but I think you're headed in the right direction.
There may be some differences in the available functions from the most recent version of @stellar/stellar-sdk
, which might affect some of the notes I left you. #23 will be upgrading that package to v12.3.0
, so even if you need to incorporate that update into this PR, it'll be a package-wide change soon.
Edit: I just merged #23 into main
, so just merge that back into your branch and yarn install
again, and you should be set!
@ElliotFriend please look through this PR |
@Ugo-X I think I got this worked out. removed an old rollup configuration, and now we "should" be all set for both build/dev environments. Give it another shot, and let me know how it gets on. |
alright ser |
@ElliotFriend please review again ser |
🫠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty good start! I left some feedback throughout.
I think the next step for you is to work out actually using the contract client after someone has saved/loaded/etc. a smart contract address.
Let me know if you have any trouble or questions. Thanks!
closes #8