Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid epipole check in match_for_triangulation #36

Closed
adelpit opened this issue Feb 25, 2021 · 0 comments · Fixed by #199
Closed

Invalid epipole check in match_for_triangulation #36

adelpit opened this issue Feb 25, 2021 · 0 comments · Fixed by #199
Assignees
Labels
bug Something isn't working

Comments

@adelpit
Copy link
Contributor

adelpit commented Feb 25, 2021

Re-posting this upstream issue here:

The epipole check for triangulating new points is being performed even if reproject_to_bearing returns false and epiplane_in_keyfrm_2 is invalid. This can happen for, for example, perspective cameras when the epipole is not visible. The resulting value of epiplane_in_keyfrm_2 is not normalized which can cause a significant number of potential matches to fail this check.

The fix is in this upstream PR. It can be a very important fix if a perspective camera moves laterally so that the epipole is not in the field of view.

@ymd-stella ymd-stella added the bug Something isn't working label Jun 12, 2021
@ymd-stella ymd-stella linked a pull request Nov 19, 2021 that will close this issue
@ymd-stella ymd-stella self-assigned this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants