Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payload with blob : INVALID #2751

Open
advaita-saha opened this issue Oct 18, 2024 · 3 comments
Open

payload with blob : INVALID #2751

advaita-saha opened this issue Oct 18, 2024 · 3 comments
Labels
bug Something isn't working EL txpool tx pool related issue

Comments

@advaita-saha
Copy link
Contributor

When a payload with blob is there, it is getting rejected
INF 2024-10-18 07:42:05.624+00:00 execution payload invalid from EL client newPayload topics="gossip_blocks" executionPayloadStatus=INVALID executionPayload="(parent_hash: \"309b299e\", fee_recipient: \"8943545177806ed17b9f23f0a21ee5948ecaa776\", state_root: \"c24b5616\", receipts_root: \"80a83e7d\", prev_randao: \"7098efd0\", block_number: 30, gas_limit: 29133471, gas_used: 84000, timestamp: 1729237325, extra_data: \"\", base_fee_per_gas: \"18489556\", block_hash: \"e9dda6a5\", num_transactions: 4, num_withdrawals: 0, blob_gas_used: \"0\", excess_blob_gas: \"0\")" blck="(blck: (slot: 47, proposer_index: 46, parent_root: \"6f5b6cf9\", state_root: \"bec7c519\", eth1data: (deposit_root: d70a234731285c6804c2a4f56711ddb8c82c99740f207854891028af34e27e5e, deposit_count: 0, block_hash: e2fcaff0592b123e48445f690b09fc132b0b8d770984a27072ec4c3aad392425), graffiti: \"1-nimbus-nimbus\", proposer_slashings_len: 0, attester_slashings_len: 0, attestations_len: 18, deposits_len: 0, voluntary_exits_len: 0, sync_committee_participants: 512, block_number: 30, block_hash: \"0xe9dda6a589397173ccd1594dee2302381bfa0ad11acf76ba83ac956c76ced73f\", parent_hash: \"0x309b299ebd8a262a032c6b29df653d8e0363af055621eb31b6c7c267f606db70\", fee_recipient: \"0x8943545177806ed17b9f23f0a21ee5948ecaa776\", bls_to_execution_changes_len: 0, blob_kzg_commitments_len: 4), signature: \"98506d91\")"
-> From kurtosis assertor blob transaction test

@advaita-saha
Copy link
Contributor Author

Exact error isolated

NTC 2024-10-18 16:40:07.080+00:00 Failed to import block                     hash=0xf6be0c5ef8aabd3c6379062e3d5dc89fab8e791c468582a3b6103103b2c27f7b number=19 error="calculated blobGas not equal header.blobGasUsed"

@advaita-saha
Copy link
Contributor Author

Block production issue.
When transactions are in the txpool with blobs, and vmState is used to calculate the blobGasUsed it always returns 0. Thus a wrong payload is generated with the fcu call with attributes

@jangko
Copy link
Contributor

jangko commented Oct 19, 2024

looks like when doing txpool refactoring, the blobGasUsed calculation in txpool is somehow removed. and there is no test covering this case.

@jangko jangko added bug Something isn't working txpool tx pool related issue EL labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EL txpool tx pool related issue
Projects
None yet
Development

No branches or pull requests

2 participants