Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes on moving toward newer nightly Rust #760

Open
weikengchen opened this issue Jul 27, 2024 · 0 comments
Open

Notes on moving toward newer nightly Rust #760

weikengchen opened this issue Jul 27, 2024 · 0 comments

Comments

@weikengchen
Copy link
Contributor

weikengchen commented Jul 27, 2024

This is a note that summarizes some changes that would be needed to move stwo into a more recent nightly version of Rust.

  • slice_flatten feature used to be defined over flatten. It has been changed to be over as_flattened and has been stablized.
  • target_feature = "avx2f" would be considered incorrect. Use target_feature = "avx2" instead
  • slice_group_by feature used to be defined over group_by. It has been changed to be over chunk_by and has been stablized.
  • One .collect::<Result<_, _>>()? would be considered incompatible with future version because the compiler thinks it would fail if ! and () are no longer considered the same type. This compiler's complaint can be addressed by changing it to .collect::<Result<(), _>>()?.
  • array_methods, slice_group_by, slice_flatten, stdsimd, slice_first_last_chunk doesn't need to be brought up as features in the lib.rs.

Remaining issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant