Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PartialEq to StarknetApiError #296

Merged
merged 1 commit into from
Jul 14, 2024
Merged

feat: add PartialEq to StarknetApiError #296

merged 1 commit into from
Jul 14, 2024

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Jul 14, 2024

This will mainly help test writers, who can now assert_eq! on StarknetApiResults.


This change is Reviewable

This will mainly help test writers, who can now `assert_eq!` on
`StarknetApiResult`s.
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @giladchase)


src/serde_utils.rs line 79 at r1 (raw file):

/// The error type returned by the inner deserialization.
// If you need `eq`, add `impl Eq fro InnerDeserializationError {}` and read warning below.

typo

Suggestion:

for

@giladchase giladchase merged commit 0b49c07 into main Jul 14, 2024
5 of 6 checks passed
@giladchase giladchase deleted the gilad/error-eq branch July 14, 2024 12:54
Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion


src/serde_utils.rs line 79 at r1 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

typo

whoops sorry, was over-eager.
Fixed here: #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants