Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_l1_provider): getting things ready for the client #2648

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

giladchase
Copy link
Contributor

Adding provider-side boilerplate for provider-batcher communication

@giladchase giladchase requested a review from elintul December 12, 2024 04:17
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Dec 12, 2024

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.626 ms 34.903 ms 35.207 ms]
change: [+1.0993% +1.9128% +2.8530%] (p = 0.00 < 0.05)
Performance has regressed.
Found 22 outliers among 100 measurements (22.00%)
2 (2.00%) high mild
20 (20.00%) high severe

@giladchase giladchase force-pushed the gilad/async-funcs-provider branch from 235c792 to fed6b21 Compare December 12, 2024 04:33
@giladchase giladchase changed the title chore(starknet_l1_provider): Getting things ready for the client chore(starknet_l1_provider): getting things ready for the client Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (e3165c4) to head (0b3f420).
Report is 820 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_l1_provider/src/lib.rs 0.00% 12 Missing ⚠️
crates/starknet_l1_provider/src/communication.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2648       +/-   ##
===========================================
+ Coverage   40.10%   77.04%   +36.94%     
===========================================
  Files          26      395      +369     
  Lines        1895    42589    +40694     
  Branches     1895    42589    +40694     
===========================================
+ Hits          760    32813    +32053     
- Misses       1100     7480     +6380     
- Partials       35     2296     +2261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Adding provider-side boilerplate for provider-batcher communication
@giladchase giladchase force-pushed the gilad/async-funcs-provider branch from fed6b21 to 0b3f420 Compare December 12, 2024 05:20
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@giladchase giladchase merged commit b3c6b00 into main Dec 12, 2024
23 checks passed
@giladchase giladchase deleted the gilad/async-funcs-provider branch December 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants