Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return vector of SequencerNodeConfig in create config function #2638

Open
wants to merge 1 commit into
base: spr/main/927ec671
Choose a base branch
from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/flow_test_setup.rs line 38 at r1 (raw file):

    pub task_executor: TokioExecutor,
    pub sequencer_0: SequencerSetup,
    pub sequencer_1: SequencerSetup,

These vars represent the dpeloyed nodes.
Each should have its own config, handle, storage, etc., all detailed within the SequencerSetup.

I would have expected this pr to add a function similar to new_from_tx_generator(tx_generator: &MultiAccountTransactionGenerator), e.g., new_from_tx_generator_remote_setup(tx_generator: &MultiAccountTransactionGenerator) (just a temp name), that will init FlowTestSetup in the expected manner.

Code quote:

    pub sequencer_0: SequencerSetup,
    pub sequencer_1: SequencerSetup,

crates/starknet_integration_tests/src/flow_test_setup.rs line 99 at r1 (raw file):

    pub sequencer_node_handles: Vec<JoinHandle<Result<(), anyhow::Error>>>,

    pub configs: Vec<SequencerNodeConfig>,

I'm confused, I thought there each SequencerSetup is exactly a single deployment. If so, then it should hold exactly one handle and exactly one config.

Code quote:

    pub sequencer_node_handles: Vec<JoinHandle<Result<(), anyhow::Error>>>,

    pub configs: Vec<SequencerNodeConfig>,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants