Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mock system mode enum #2632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.00%. Comparing base (e3165c4) to head (b89d319).
Report is 814 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
- Coverage   40.10%   35.00%   -5.10%     
==========================================
  Files          26      277     +251     
  Lines        1895    32227   +30332     
  Branches     1895    32227   +30332     
==========================================
+ Hits          760    11282   +10522     
- Misses       1100    19938   +18838     
- Partials       35     1007     +972     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/definitions.rs line 5 at r1 (raw file):

    Local,
    Remote,
}

Please unify this with the pr that uses this, it's too out of context as is 🙏

Code quote:

#[derive(Debug, Clone)]
pub enum MockSystemMode {
    Local,
    Remote,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants