Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_state_sync): pass new internal blocks from state sync to p2p sync client #2631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

chore: fix CR comments

365db40
Select commit
Loading
Failed to load commit list.
Open

feat(starknet_state_sync): pass new internal blocks from state sync to p2p sync client #2631

chore: fix CR comments
365db40
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 1s

77.08% (+36.97%) compared to e3165c4

View this Pull Request on Codecov

77.08% (+36.97%) compared to e3165c4

Details

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (e3165c4) to head (365db40).
Report is 816 commits behind head on main.

Files with missing lines Patch % Lines
crates/starknet_state_sync/src/lib.rs 0.00% 9 Missing ⚠️
crates/starknet_state_sync/src/runner/mod.rs 0.00% 5 Missing ⚠️
crates/starknet_state_sync_types/src/errors.rs 0.00% 3 Missing ⚠️
crates/papyrus_node/src/run.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2631       +/-   ##
===========================================
+ Coverage   40.10%   77.08%   +36.97%     
===========================================
  Files          26      393      +367     
  Lines        1895    42577    +40682     
  Branches     1895    42577    +40682     
===========================================
+ Hits          760    32819    +32059     
- Misses       1100     7463     +6363     
- Partials       35     2295     +2260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.