Update panic.rs #6582
Open
Update panic.rs #6582
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @GradleD)
a discussion (no related file):
please add what is the aim of this PR in the commit message.
GradleD
commented
Nov 5, 2024
orizi
requested changes
Nov 5, 2024
There was a problem hiding this comment.
update the PR title.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @GradleD)
a discussion (no related file):
please answer questions in https://reviewable.io/reviews/starkware-libs/cairo/6582#-.
additionally - your commit message seems to have nothing to do with what is actually happening.
specifically - to add doc- you just need to implement InlineMacroExprPlugin's documentation method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.