Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Saturation Arithmetic is incorrect with negative signed integers #6462

Closed
bengineer42 opened this issue Oct 7, 2024 · 0 comments · Fixed by #6465 · May be fixed by #6463
Closed

bug: Saturation Arithmetic is incorrect with negative signed integers #6462

bengineer42 opened this issue Oct 7, 2024 · 0 comments · Fixed by #6465 · May be fixed by #6463
Labels
bug Something isn't working

Comments

@bengineer42
Copy link

Bug Report

Cairo version:
2.8.4

Current behavior:

let a: i8 = 127;
let b: i8 = -127;

let c = a.saturating_sub(b);

would give -128

Expected behavior:

Above should give 127

Steps to reproduce:

Above using the SaturatingSub Trait

Related code:

https://github.com/starkware-libs/cairo/blob/main/corelib/src/num/traits/ops/saturating.cairo#L22-L58
https://github.com/starkware-libs/cairo/blob/main/corelib/src/integer.cairo#L2965-L2988

Other information:
@bengineer42 bengineer42 added the bug Something isn't working label Oct 7, 2024
@bengineer42 bengineer42 mentioned this issue Oct 7, 2024
Open
orizi added a commit that referenced this issue Oct 7, 2024
@orizi
Made signed int add and sub more efficient.
0a2e337 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
@orizi orizi mentioned this issue Oct 7, 2024
Merged
orizi added a commit that referenced this issue Oct 7, 2024
@orizi
Made signed int add and sub more efficient.
b4e75a1 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
orizi added a commit that referenced this issue Oct 7, 2024
@orizi
Made signed int add and sub more efficient.
6461cd2 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
orizi added a commit that referenced this issue Oct 8, 2024
@orizi
Made signed int add and sub more efficient.
adcf8fc 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
orizi added a commit that referenced this issue Oct 10, 2024
@orizi
Made signed int add and sub more efficient.
c93f0b0 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
orizi added a commit that referenced this issue Oct 10, 2024
@orizi
Made signed int add and sub more efficient.
a7d0fc7 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
orizi added a commit that referenced this issue Oct 10, 2024
@orizi
Made signed int add and sub more efficient.
be90c7d 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
orizi added a commit that referenced this issue Oct 10, 2024
@orizi
Made signed int add and sub more efficient.
d472062 
Fixing issue with returning the proper saturating value on
`Saturating{Add,Sub}`.

Fixing #6462.

commit-id:861630ee
This was linked to pull requests Oct 10, 2024
Fixed saturating arithmetic with negative signed integers #6463
Open
Made signed int add and sub more efficient. #6465
Merged
@orizi orizi closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@orizi @bengineer42