Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Default to GET for item search? #643

Open
gadomski opened this issue Feb 19, 2024 · 2 comments
Open

[RFC] Default to GET for item search? #643

gadomski opened this issue Feb 19, 2024 · 2 comments
Labels
question Further information is requested

Comments

@gadomski
Copy link
Member

Since POST is recommended but not required, it can be surprising to users when pystac-client defaults to POST (e.g. #641). On the other hand, any sort of complicated intersects will probably blow up a GET request. I'm not quite sure what the most user-friendly logic is here, anyone have thoughts?

@gadomski gadomski added the question Further information is requested label Feb 19, 2024
@gadomski
Copy link
Member Author

From @philvarner in Slack:

landing page link -- if it has a link with rel=search without a method field, it assumed to be GET
a link with method = POST defines that it supports post, and likewise with GET

We should check the landing page and default to GET if it doesn't have a POST search link.

@philvarner
Copy link
Collaborator

maybe also have an override to force POST regardless of what's advertised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants