Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional parameters via a "public" interface #582

Open
gadomski opened this issue Aug 29, 2023 · 0 comments
Open

Allow additional parameters via a "public" interface #582

gadomski opened this issue Aug 29, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gadomski
Copy link
Member

Currently, a user could modify _parameters on an item search to add other parameters to a request:

def get_parameters(self) -> Dict[str, Any]:
if self.method == "POST":
return self._parameters
elif self.method == "GET":
return self._clean_params_for_get_request()
else:
raise Exception(f"Unsupported method {self.method}")

We should add a "public" interface to this attribute, probably set_parameter(key, value). One use-case would be to test pystac-client with new/proposed API extensions without needed to touch the "private" interface or modify pystac-client itself.

@gadomski gadomski added the enhancement New feature or request label Aug 29, 2023
@gadomski gadomski added the good first issue Good for newcomers label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant