Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would have been better if the release notes for Spring Boot 2.3.0 contained a hint about a breaking change in the Jackson dependency #22259

Closed
Bas83 opened this issue Jul 8, 2020 · 1 comment
Labels
type: wiki-documentation A documentation update required on the wiki

Comments

@Bas83
Copy link

Bas83 commented Jul 8, 2020

In the release notes of Spring Boot 2.3.0 at https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.3-Release-Notes there is no mention of a breaking change in the Jackson update to version 2.11.0 which formats the timezone offset with an additional colon, as per issue at FasterXML/jackson-databind#2643

While we should have found this ourselves too (we didn't use exact String testing in our tests but immediately parsed to our DTO's too), this resulted in us finding out by a customer integrating with our API contacting us about it. We have updated our tests with some more low-level String validation, however it would have been nice to find out about this in the release notes of Spring Boot too. I understand this comes from a dependency update but it is rather important. As mentioned in the Jackson ticket they have additional plans to use Z instead of 00:00 for zero offsets:
"Yes, retain 00:00 for the 2.x line and move fully to XXX in 3.0. I wouldn't really touch that in 2.x as it cause too many confusion with broken stuff out there. Don't make the hodge-podge even worse for now."
So be aware this will happen again in Jackson 3.0 as well.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 8, 2020
@wilkinsona
Copy link
Member

Thanks for the suggestion. I've added a small section to the release notes.

@wilkinsona wilkinsona added type: wiki-documentation A documentation update required on the wiki and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: wiki-documentation A documentation update required on the wiki
Projects
None yet
Development

No branches or pull requests

3 participants