Make sure site is on doxia 1 #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenarc doesn't work for the groovy version we are using nor does it handle modern java properly. The plugin will need separately forked and updated to continue using, for now, just disable it as the code is pretty well written that it is not likely to complain much.
… clear doxia 1 support issue
elharo
approved these changes
Dec 2, 2024
elharo
reviewed
Dec 2, 2024
There was a problem hiding this comment.
JDK 24 build is failing:
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project spotbugs-maven-plugin: Compilation failure
Error: java.lang.ExceptionInInitializerError
Error: at lombok.javac.apt.LombokProcessor.placePostCompileAndDontMakeForceRoundDummiesHook(LombokProcessor.java:174)
Error: at lombok.javac.apt.LombokProcessor.init(LombokProcessor.java:96)
Error: at lombok.core.AnnotationProcessor$JavacDescriptor.want(AnnotationProcessor.java:160)
Error: at lombok.core.AnnotationProcessor.init(AnnotationProcessor.java:213)
Error: at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.init(AnnotationProcessor.java:64)
Error: at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:699)
Error: at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:826)
Error: at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:922)
Error: at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1265)
Error: at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1378)
Error: at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1271)
Error: at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:947)
Error: at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:319)
Error: at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:178)
Error: at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:66)
Error: at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:52)
Error: Caused by: java.lang.NoSuchFieldException: com.sun.tools.javac.code.TypeTag :: UNKNOWN
Error: at lombok.permit.Permit.getField(Permit.java:144)
Error: at lombok.javac.JavacTreeMaker$SchroedingerType.getFieldCached(JavacTreeMaker.java:171)
Error: at lombok.javac.JavacTreeMaker$TypeTag.typeTag(JavacTreeMaker.java:259)
Error: at lombok.javac.Javac.<clinit>(Javac.java:187)
Error: ... 16 more
Error: -> [Help 1]
|
Probably not related, but I would turn this pat of the CI off. Sticking to released LTS JDKs reduces the runtime and cost of the CI. |
|
Thanks, I'm aware 24 is failing as it requires lombok to get a patch out projectlombok/lombok.patcher#17 then new release here projectlombok/lombok#3772. My primary reason is to confirm groovy, asm, bcel and its sort of an alert for me that lombok is a blocker. That keeps me from globally adding to my other repos as I have scripts that will blast all GHA with the update. They would all fail at that point and I'm trying to use 24 if I can ;) but had to drop back locally as a result. Since an entire month over there has been ignored at this point, it does make sense for me to just disable it for now because who knows how long its going to take to apply simple patches there and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue reported by @elharo with site:site run.