-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy_asset{_file}
to doc/extdev/utils
#13077
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a good addition to me.
@AA-Turner Do you have future plans in making sphinx.util.*
more private or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on sphinx.util.osutil.copyfile()
? copy_asset{_file}
are really only useful if you want to render Jinja templates
copy_asset{_file}
to doc/extdev/utils
Co-authored-by: Adam Turner <[email protected]>
Ah, I thought the rendering was acting as an optional addition, but you make a good point. My use case is that I was playing around with a new extension and (under the current implementation) needed to copy a directory of files to the So in that instance, is it recommended to implement that recursively with Or, would would best practice be to not use Sphinx for that functionality? |
To copy a directory, I would reach for Although, this raises a different feature request. Themes can copy static files via A |
Add
copy_asset()
andcopy_asset_file()
to the Sphinx API > Utilities page.Preview:
Feature or Bugfix
Purpose
The page documents utility classes and functions to develop extensions with and I feel like
copy_asset()
andcopy_asset_file()
are common/valuable functions for extension development and should be highlighted in the docs.The functions were added in version 1.5 via this PR: #2744