Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches for other extensions even though the config type is set to a different type #1843

Open
3 tasks done
TheDevMinerTV opened this issue May 30, 2024 · 1 comment
Open
3 tasks done
Labels
kind/bug Something isn't working

Comments

@TheDevMinerTV
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.
  • I have checked the troubleshooting guide for my problem, without success.

Viper Version

1.18.2

Go Version

1.22.3

Config Source

Files

Format

YAML

Repl.it link

https://replit.com/@TheDevMinerTV/viper-extensionless-repro

Code reproducing the issue

No response

Expected Behavior

Viper should only look at files ending with the config type set, if it has been set.
Viper's README reads:

viper.SetConfigType("yaml") // REQUIRED if the config file does not have the extension in the name

I'd expect this to limit the search to only *.yaml files.

Actual Behavior

Viper checks all different kinds of files, also the one without no extension. This is usually the application's binary which obviously isn't a parsable configuration file.

Steps To Reproduce

  1. Add . to the config path
  2. Set the config type to whatever you want (just not an empty string, for example "yaml")
  3. Set the config name to the same as your binary (for example "myapp")
  4. Compile your application (so it's called, for example ./myapp) and run it

Additional Information

No response

@TheDevMinerTV TheDevMinerTV added the kind/bug Something isn't working label May 30, 2024
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@TheDevMinerTV TheDevMinerTV changed the title Extensionless Searches for other extensions even though the config type is set to a different type May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant