Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

red value mismatch, but only because of rounding #86

Closed
sgbaird opened this issue Oct 5, 2022 · 1 comment
Closed

red value mismatch, but only because of rounding #86

sgbaird opened this issue Oct 5, 2022 · 1 comment

Comments

@sgbaird
Copy link
Member

sgbaird commented Oct 5, 2022

Best to either round internally or throw an error saying that only integers are allowed aspuru-guzik-group/olympus#19

@sgbaird
Copy link
Member Author

sgbaird commented Oct 22, 2022

Rounding is implemented in the Python package, and the device code issues a non-catastrophic ValueError if one of the colors isn't an integer between 0 and 255. #99

@sgbaird sgbaird closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant