Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define custom bots to exclude #42

Open
lyne-bot opened this issue Mar 11, 2020 · 4 comments
Open

Define custom bots to exclude #42

lyne-bot opened this issue Mar 11, 2020 · 4 comments

Comments

@lyne-bot
Copy link

In fame/github_tracker.py you have some bot-names hardcoded. Would be nice if one could add additional bot-names or other github-account via the gui on sourcerer.

Example-Repo: https://github.com/lyne-design-system/lyne-components

In our case:

  • semantic-release-bot will update the package.json after successfull release, which we would like to exclude from the hall of fame.
  • travis pushes the file DEPLOYMENTS.md back to the repo after a successfull release. It does it with the admin account from our organisation. But no human developer is using that account, so we would like to exclude that one as well.

Do you think that is possible? Or did I miss something in the documentation?

Thank you very much for your efforts
yves

@sergey48k
Copy link
Member

Hi @lyne-admin ,

As a temp measure, I can accept a PR that blacklists your bots:

image

https://github.com/sourcerer-io/hall-of-fame/blob/develop/fame/github_tracker.py

@feerglas
Copy link
Contributor

Hi @sergey48k
Thanks for your answer. I created a pull-request:
#44

@sergey48k
Copy link
Member

@feerglas : I merged your request (thanks!), will push it to prod in the couple of days. Will ping you here once it's done.

@feerglas
Copy link
Contributor

@sergey48k thank you very much, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants