Add positive/negative review endpoint

[KaemonIsland]

We need a way for users to vote if a review was helpful or not.

[seandawes]

This would than also allow for filtering of reviews of high to low by helpful score as currently reviews just turn into a pagination series after whatever amount you choose to show as viewable on a product page.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[seandawes]

bump to keep this issue open

[fthobe]

@KaemonIsland @seandawes We are working on that, is any of you:

• having this feature already?
• made changes to the review extension?
• has any suggestions how this feature should look like beyond a basic positive / negative counter?

[fthobe]

Following up a discussion on the public slack there's has been indicated a general interest to have this feature inside the extensions.

This includes:

• a thumbs up endpoint
• a thumbs down endpoint
• a report endpoint
• an admin interface to visualise / delete reported reported reviews

[fthobe]

@kennyadsl @jarednorman @tvdeyen working through the extensions we found a lot of stuff that could possibly be realigned to what became standard (thumbs up / thumbs down / report).

The extension lists a magnitude of feedback options that we could (in my oppinion) reduce to a simple thumbs up thumbs down and remove in the next major. Also "Display unapproved Reviews" and "Include unapproved Reviews" seems ambigous wording. Given that this extension is according to you hardly used maybe we can benefit from reducing the footprint here.

Can we deprecate this in favor of thumbs up / thumbs down / report?

[jarednorman]

What you're suggesting is pretty serious breaking change, even if it's a good one. This makes me think we'd be better off forking this (or providing a legacy fork), unless you have plans for an upgrade path.

[fthobe]

@jarednorman I suggest versioning here. Honestly it's a total mess frontend and backend. The extension makes extensive use of jquery and uses 14 years old jquery components that can be easily substituted with some CSS and clean jscript. I'd opt for reusing the api in reduced form and a new major release with breaking issues documented in release notes mantaining the old version in a legacy fork.

[jarednorman]

I'm fine with either one of these options:

1. Create and release a solidus_legacy_reviews gem that's a fork of this gem in its current state, document that existing users should use that, then bump the major version of this project and make whatever hard breaking changes we need.
2. Fork this gem (call it solidus_product_reviews or something) and make all the new breaking changes there.

I don't have time to actually do either of those things right now, but I'm happy with either. The second option is less work.

[tvdeyen]

I second Jared here. Could be a great opportunity to move the extension over to the main solidus github org as well.

[fthobe]

If someone is willing to write 30 lines on how to create a new route inside an extension and use it in the starter frontend from start to finish we can do that.

[kennyadsl]

In the extension install generator, in case of starter fronted, you can use the route method to inject new routes in the host application.

Refs:

• https://guides.rubyonrails.org/v8.0/generators.html
• https://api.rubyonrails.org/v8.0.0.1/classes/Rails/Generators/Actions.html#method-i-route
• https://github.com/solidusio/solidus_subscriptions/blob/main/lib/generators/solidus_subscriptions/install/install_generator.rb (unfortunately, we don't have any route here, but it's an example of install script that works with the starter_frontend)

You should have all the pieces now. 😉

[fthobe]

Ok, A couple of additional questions.

So we need:

• a five star scale for review
• A review comment
• a report abuse button
• a thumbs up / thumbs down feature to allow users to tag a review as useful or not
• the existing admin interface to approve / discard reviews and monitor reports

What we can discard:

• all review the review features with 5 star scales in favor of thumbs up / thumbs down
• all legacy frontend code
• all old jquery / jquery review scripts in favor of aligning the solution with clean jscript / CSS that's aligned with the starter_frontend

Some issues came up:

• the current admin frontend for reviews does not load
• the current configuration interface of the review settings is not changing any settings nor do I see any trace in the code or server where they should go

Here comes the big question:

• we can contribute the changes but I would like to receive the extension in a more or less working state regarding the admin interface, would anybody of core commit to fire up a container or vm and do the minor fixes required to make the backend work @tvdeyen @jarednorman @kennyadsl

[fthobe]

I'm fine with either one of these options:

1. Create and release a solidus_legacy_reviews gem that's a fork of this gem in its current state, document that existing users should use that, then bump the major version of this project and make whatever hard breaking changes we need.
2. Fork this gem (call it solidus_product_reviews or something) and make all the new breaking changes there.

I don't have time to actually do either of those things right now, but I'm happy with either. The second option is less work.

@jarednorman I think @tvdeyen had a fair suggestion. Let's finish this up in a new repo moved from contrib to solidusio and just archive this one. This way we don't break anything and don't leave anybody worse off than before.

[tvdeyen]

@jarednorman I think @tvdeyen had a fair suggestion. Let's finish this up in a new repo moved from contrib to solidusio and just archive this one. This way we don't break anything and don't leave anybody worse off than before.

We have not decided anything, yet. Also we cannot just archive an extension stores are using. Please create your repo first and we maybe transfer it when we think we are willing to maintain it.

[fthobe]

@tvdeyen I suggest we leave this issue open and move to a new issue outlining the outcome we want to reach with a new review extension. I extended #124 for that purpose.