Fix transaction header encoding #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddelnano did you ever get this working?? |
|
@noisyscanner I actually don't remember what state I left this in other than that this PR didn't do what I was hoping. I'll try to revisit this issue this week. |
|
@ddelnano that's sound, let me know if you find anything :) I tried to have a brief look but I have noooo idea what's going on 🙃 |
|
Yea using the gob encoding makes this much more complicated :). I think I wanted to see if I could switch it to use json encoding so that this issue either goes away or when a bug comes up its easy to tcpdump and see the data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
transaction.Transaction.Request.Headersandtransaction.Transaction.Real.Headersasmap[string][]stringinstead ofmap[string]interface{}map[string]interface{}The intent of this PR is to fix #12 . Still having some issues with the api blueprint and go web server in #12 so this is a WIP still.