Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with BundleCeres for windows system #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aki34
Copy link

@aki34 aki34 commented Apr 22, 2018

As I mentioned in Issues, these two files (time-unix.h and time-unix.cpp) are needed for building with windows system.
Also I found difference between rot2aa() and ceres::RotationMatrixToAngleAxis and between aa2rot() and ceres::AngleAxisToRotationMatrix.
The sign is different in the output of each function
image

aki34 added 3 commits April 22, 2018 18:23
modified not to use rot2aa and aa2rot
It's correct to use rot2aa and aa2rot.
@RamadanAhmed
Copy link

I think the reason being ceres Matrix are in column major form and rot2aa and aa2rot are in row major form so you only need to transpose the matrix or multiply angle-axis by -1 to get the correct result. hope it will help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants