Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 90 char limit #10

Closed
arshbot opened this issue Aug 25, 2020 · 2 comments
Closed

Remove 90 char limit #10

arshbot opened this issue Aug 25, 2020 · 2 comments

Comments

@arshbot
Copy link

arshbot commented Aug 25, 2020

Yes, BIP-0173 specifies a max 90 char limit for addresses, however bech32 encoding is used outside of bitcoin, specifically in Lightning Network's Bolt11 where the majority of payment requests are encoded in bech32, and whose size is significantly larger than 90 chars most of the time.

Enforcing the limit makes this tool unusable for anything Lightning Network related, I request that the limitation is removed. I can supply the simply PR removing the relevant code

@slowli
Copy link
Owner

slowli commented Aug 28, 2020

@arshbot Yeah, makes sense. I think it could make sense to think about some "smart" solution (i.e., restricting the input buffer length by default and allowing longer buffers on an explicit opt-in), but I'm quite fine with a simple solution initially.

@arshbot
Copy link
Author

arshbot commented Sep 25, 2020

I spent some time working on this issue @slowli and decided that the scope of this issue has grown beyond this ticket. Please see the new ticket I've opened up.

#12

@arshbot arshbot closed this as completed Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants