Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make definition of k-neighborhood more rigorous #1106

Open
lisa-wm opened this issue Jun 7, 2023 · 6 comments
Open

make definition of k-neighborhood more rigorous #1106

lisa-wm opened this issue Jun 7, 2023 · 6 comments
Assignees
Labels
Milestone

Comments

@lisa-wm
Copy link
Collaborator

lisa-wm commented Jun 7, 2023

in particular, we don't state how the $x^{(i)}$ are defined (ranking according to distances, but is $x$ itself included?)

image

@ludwigbothmann
Copy link
Contributor

x can be any point in the feature space. the x_i are features of the data points in the data set. perhaps we should change the part before the | to x_i \in foo where foo is the feature-part of \D (I guess we do not have a symbol for that, yet)?

@ludwigbothmann
Copy link
Contributor

Ne, lass uns das so machen: Replace \xi by x^star (twice). That way it cannot be confused with an element from the training data set.

@ludwigbothmann
Copy link
Contributor

Perhaps it would also be better to not call the k-th nearest neighbour x^k because this is reserved for the feature vector in the k-th row of the training data set? We would need a different symbol in that case, perhaps just x_k? Could then be confused with the k-th column, I know :-)

@ludwigbothmann ludwigbothmann added this to the do-this-soon milestone Jun 15, 2023
@ludwigbothmann
Copy link
Contributor

ludwigbothmann commented Jun 15, 2023

@lisa-wm I set a milestone with due date for this so that we do this next week 🤝 (Not sure what happens after the due date, so I will set it on next Monday to investigate it :) )

@ludwigbothmann
Copy link
Contributor

well, I did not get any reminder, did you @lisa-wm ?

@lisa-wm
Copy link
Collaborator Author

lisa-wm commented Nov 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants