Fix population of interface signatures

slackhq · Oct 17, 2024 · a333301 · a333301
1 parent e0426ea
commit a333301
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 36 deletions.
diff --git a/src/orchestrator/populator.rs b/src/orchestrator/populator.rs
@@ -741,42 +741,8 @@ fn inherit_methods_from_parent(
             }
         }
 
-        if let Some(existing_declaring_class) = storage.declaring_method_ids.get(method_name) {
-            if existing_declaring_class != declaring_class {
-                let existing_declaring_class_storage = if existing_declaring_class == &storage.name
-                {
-                    &storage
-                } else if let Some(storage) = codebase.classlike_infos.get(existing_declaring_class)
-                {
-                    storage
-                } else {
-                    continue;
-                };
-
-                if !matches!(existing_declaring_class_storage.kind, SymbolKind::Interface) {
-                    if let Some(functionlike_storage) = codebase
-                        .functionlike_infos
-                        .get(&(existing_declaring_class_storage.name, *method_name))
-                    {
-                        if let Some(method_info) = &functionlike_storage.method_info {
-                            if !method_info.is_abstract {
-                                continue;
-                            }
-
-                            if let Some(functionlike_storage) = codebase
-                                .functionlike_infos
-                                .get(&(storage.name, *method_name))
-                            {
-                                if let Some(method_info) = &functionlike_storage.method_info {
-                                    if method_info.is_abstract {
-                                        continue;
-                                    }
-                                }
-                            }
-                        }
-                    }
-                }
-            }
+        if let Some(_) = storage.declaring_method_ids.get(method_name) {
+            continue;
         }
 
         storage

diff --git a/tests/inference/Interface/refineInterfaceThenCall/input.hack b/tests/inference/Interface/refineInterfaceThenCall/input.hack
@@ -0,0 +1,15 @@
+interface I {
+    public function foo(): arraykey;
+}
+
+interface IChild extends I {
+    public function foo(): string;
+}
+
+function bar(I $i): string {
+    if ($i is IChild) {
+        return $i->foo();
+    } else {
+        return '';
+    }
+}