Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocha: done to promise transform #33

Open
Vanuan opened this issue Feb 21, 2017 · 2 comments
Open

Mocha: done to promise transform #33

Vanuan opened this issue Feb 21, 2017 · 2 comments

Comments

@Vanuan
Copy link

Vanuan commented Feb 21, 2017

In mocha it is possible to write this:

beforeAll((done) => {
  done();
});

Jasmine requires a promise to be returned. Is it possible to rewrite this to the following:

beforeAll(() => {
  let promise = new Promise((resolve, reject) => {
    resolve();
  });
  return promise;
});
@skovhus
Copy link
Owner

skovhus commented Feb 22, 2017

Thanks for reporting this! Feel free to submit a pull request, maybe you want to give it a try? : )

@Vanuan
Copy link
Author

Vanuan commented Feb 22, 2017

No, I'll use manual labor for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants