You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Fails to fetch images with get_images from danbooru in case the result contains a taken down image (flagges by is_banned). It throws "ValueError: Failed to get data"
To Reproduce
Ask for enough images with get_images from danbooru
Expected behavior
Just skip over the post and return the images
Desktop (please complete the following information):
OS: Debian Bullseye
Python 3.10
Additional context
I fixed the bug by modifying the parser code and will propose a pull request referencing the issue. Also, I'd suggest removing try except block from danbooru where it says "ValueError(f"Failed to get data") as it is not descriptive and I had to remove it to track down the issue myself. I will do it in the pull request.
The text was updated successfully, but these errors were encountered:
Describe the bug
Fails to fetch images with get_images from danbooru in case the result contains a taken down image (flagges by is_banned). It throws "ValueError: Failed to get data"
To Reproduce
Ask for enough images with get_images from danbooru
Expected behavior
Just skip over the post and return the images
Desktop (please complete the following information):
Additional context
I fixed the bug by modifying the parser code and will propose a pull request referencing the issue. Also, I'd suggest removing try except block from danbooru where it says "ValueError(f"Failed to get data") as it is not descriptive and I had to remove it to track down the issue myself. I will do it in the pull request.
The text was updated successfully, but these errors were encountered: