Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_images sometimes fails with danbooru #6

Open
f8upd8 opened this issue Oct 25, 2022 · 2 comments
Open

get_images sometimes fails with danbooru #6

f8upd8 opened this issue Oct 25, 2022 · 2 comments

Comments

@f8upd8
Copy link

f8upd8 commented Oct 25, 2022

Describe the bug
Fails to fetch images with get_images from danbooru in case the result contains a taken down image (flagges by is_banned). It throws "ValueError: Failed to get data"

To Reproduce
Ask for enough images with get_images from danbooru

Expected behavior
Just skip over the post and return the images

Desktop (please complete the following information):

  • OS: Debian Bullseye
  • Python 3.10

Additional context
I fixed the bug by modifying the parser code and will propose a pull request referencing the issue. Also, I'd suggest removing try except block from danbooru where it says "ValueError(f"Failed to get data") as it is not descriptive and I had to remove it to track down the issue myself. I will do it in the pull request.

@da-vinci-bot
Copy link

da-vinci-bot bot commented Oct 25, 2022

Hey! @MalOMaw You'll get a response soon! UwU


Click here to make your day UmU
abc

@da-vinci-bot da-vinci-bot bot added the triage label Oct 25, 2022
@f8upd8
Copy link
Author

f8upd8 commented Oct 25, 2022

The pull request: #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants