Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run update_biocontainers on containers in the registry #103

Open
georgiastuart opened this issue Apr 5, 2023 · 6 comments
Open

Only run update_biocontainers on containers in the registry #103

georgiastuart opened this issue Apr 5, 2023 · 6 comments

Comments

@georgiastuart
Copy link
Contributor

Describe the bug

Update biocontainers runs on a set of containers not necessarily in the registry.

To Reproduce
Steps to reproduce the behavior:

  • Create your own registry
  • Delete all the biocontainers
  • update_biocontainers still runs on all biocontainers

Expected behavior
A clear and concise description of what you expected to happen.

I'd expect it to skip containers that aren't in the registry.

Version of Singularity and Singularity Registry HPC Client

https://github.com/georgiastuart/resistry-test

@georgiastuart
Copy link
Contributor Author

I think I can fix this, I just can't do it right away so I wanted to bookmark with an issue!

@vsoch
Copy link
Member

vsoch commented Apr 5, 2023

The listing comes from the galaxy project, here https://github.com/georgiastuart/resistry-test/blob/0a803915bcc1ae525e41248721c123eb8a869462/.github/scripts/get_biocontainers.py#L34 and the purpose is to add biocontainers that aren't in the registry. Can you help me understand why this needs fixing?

@georgiastuart
Copy link
Contributor Author

My registry doesn't have any biocontainers in it and the script running tries to add them. This may be a "delete this workflow file if you don't want it" docs issue rather than a code issue!

@vsoch
Copy link
Member

vsoch commented Apr 5, 2023

Yes - we should definitely add a “delete this workflow file” to the developer tutorial! Do you want to add it or would you like me to?

@georgiastuart
Copy link
Contributor Author

I can! I should have time later today.

@vsoch
Copy link
Member

vsoch commented Apr 5, 2023

yay! Thank you! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants