Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make org.polymaps explicitly global #76

Closed
akidee opened this issue May 8, 2011 · 1 comment · May be fixed by #77
Closed

Make org.polymaps explicitly global #76

akidee opened this issue May 8, 2011 · 1 comment · May be fixed by #77

Comments

@akidee
Copy link

akidee commented May 8, 2011

When wrapping polymaps in a closure - to make it available in Yabble (CommonJS module loader) -, org.polymaps is not available in the global namespace. Defining it as a local variable is not enough.
It should be done like that:
if (!window.org)window.org={}
if(!org.polymaps)org.polymaps={}
If you agree, I will send a patch.

@akidee
Copy link
Author

akidee commented May 10, 2011

See #77

@akidee akidee closed this as completed May 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant