New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Float#floor instead of Float#round #130

Open

elkesrio opened this issue Jan 19, 2024 · 0 comments

elkesrio commented Jan 19, 2024 •

edited

Loading

This is a follow-up of simplecov-ruby/simplecov#679

I'm having a 100% test coverage with some missed lines

I suggest to stick with using Float#floor instead of round as simplecov does.

The changes would be in :

lib/simplecov-html.rb:41
lib/simplecov-html.rb:42
views/covered_percent.erb:2
views/file_list.erb:10
views/file_list.erb:61
views/file_list.erb:66
views/file_list.erb:68

Are you open to merge pull requests? I can submit one

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment