Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treemesh: default diagonal balance = True #361

Open
lheagy opened this issue Jun 5, 2024 · 2 comments
Open

treemesh: default diagonal balance = True #361

lheagy opened this issue Jun 5, 2024 · 2 comments
Labels
TreeMesh QuadTree or OcTree related

Comments

@lheagy
Copy link
Member

lheagy commented Jun 5, 2024

As we talked about in the SimPEG meeting on June 5, we should set the default for mesh creation to do a diagonal balance to prompt best practices (cc @fourndo and @dccowan who prompted the discussion!)

@lheagy lheagy added the TreeMesh QuadTree or OcTree related label Jun 5, 2024
@jcapriot
Copy link
Member

jcapriot commented Jun 5, 2024

Sounds great to me! Should just need to put in a notice on the init that the default has recently changed.

I believe it’s already set up that a serialized un-diagonal balanced mesh will still be read in consistently (for backwards compatibility), but that would be the only thing to double check.

@jcapriot
Copy link
Member

I've added a note in #382 to emit a warning that this behavoir will change in discretize v1.0, that will start showing up when the bugfix release hits soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TreeMesh QuadTree or OcTree related
Projects
None yet
Development

No branches or pull requests

2 participants