Fix accidental merge #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `deep_merge!` were inadvertently changing nested data, which masked some warnings. This adds a deep copy to the `deep_merge!` call to avoid the problem. Also: * Confine testing to supported Ruby versions * Update gems * Refactor and simplify rspec tests * Debugging additions * Make missing keys an error only on merged data
silug
force-pushed
the
20240828_updates
branch
from
4e74d0b to
44b129a
Compare
rgardner4012
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
deep_merge!were inadvertently changing nested data, whichmasked some warnings. This adds a deep copy to the
deep_merge!callto avoid the problem.
Also: