Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net8windows keyboarding and writing systems #1366

Draft
wants to merge 1 commit into
base: net8windows/sil-windows-forms
Choose a base branch
from
Draft

Net8windows keyboarding and writing systems #1366

wants to merge 1 commit into from

Conversation

josephmyers
Copy link
Collaborator

@josephmyers josephmyers commented Nov 13, 2024 •
edited by andrew-polk
Loading

This change is Reviewable

@josephmyers
.NET8 Windows for SIL.Windows.Forms.Keyboarding and .WritingSystems
44dea17 
It builds, and the tests appear to be not catastrophic, but I'll wait for the build server to do the actual verification.

For .Keyboarding, I completely removed the Linux\ folder on .NET8 Windows. Same for the test files directed at Linux.
@github-actions GitHub Actions
Copy link

Palaso Tests

     3 files  ± 0       3 suites  ±0   15m 1s ⏱️ -32s
 4 819 tests  -  5   4 593 ✅ ±0  226 💤  -  5  0 ❌ ±0 
13 986 runs   - 10  13 369 ✅ ±0  617 💤  - 10  0 ❌ ±0 

Results for commit 44dea17. ± Comparison against base commit c06c991.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both. 
SIL.Windows.Forms.Tests.ImageToolbox.ImageToolboxTests ‑ CheckMonoForSelectLargeIconView
SIL.Windows.Forms.Tests.ImageToolbox.ImageToolboxTests ‑ DoubleCheckFileFilterWorks
SIL.Windows.Forms.Tests.ImageToolbox.ImageToolboxTests ‑ ShowGeckoToolbox
SIL.Windows.Forms.Tests.ImageToolbox.ImageToolboxTests ‑ ShowToolbox
SIL.Windows.Forms.Tests.ImageToolbox.ImageToolboxTests ‑ ShowToolboxWith_PreExisting_EnsureRawFormatUnchanged
SIL.Windows.Forms.Tests.ImageToolbox.ImageToolboxTests ‑ ShowToolboxWith_PreExisting_Image_WithMetadata

SIL.Windows.Forms.Tests.SettingsProviderTests ‑ Upgrade_ExtraFields_SettingsMigrated

@josephmyers josephmyers changed the base branch from master to net8windows/sil-windows-forms November 13, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@josephmyers