Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent migration changes to info.xml file from affecting selection of version when merging HearThisPacks #196

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Jan 4, 2022

Two changes to try to accomplish this:

  1. During data migration, preserve the original file modification time. Note: for most current HT users, the latest migration that modifies this file has probably already happened, so this is not likely to help much.
  2. During the merge, omit info.xml from consideration when comparing file date/times. Currently there are only very rare situations (skipping) that this file will be changed independently of recording, so this is probably safe. However, this needs to be reviewed when the changes for HT-359 are merged because that will make it slightly more likely to change the info.xml file alone.

This change is Reviewable

@tombogle tombogle requested a review from JohnThomson January 4, 2022 16:28
@tombogle tombogle self-assigned this Jan 4, 2022
@tombogle tombogle force-pushed the prevent-info-migration-from-affecting-hearthispack-merge branch from 567d812 to a7efb56 Compare July 18, 2022 13:54
@tombogle tombogle marked this pull request as draft July 18, 2022 13:55
…ing HearThisPack files and added unit test checks for some code changes regarding preservation of modified time (that were actually incorporated as part of HT-359)
@tombogle tombogle force-pushed the prevent-info-migration-from-affecting-hearthispack-merge branch from 18fc342 to 16ba196 Compare July 18, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant